DEV Community

Discussion on: My first portfolio site. Some feeback / tips?

Collapse
 
katzy687 profile image
Natti Katz

I'll look into the root domain thing. I believe github only lets you host one site like that, but I have not used it yet.

I tried 6 rem. That is waay too big and in your face for my liking. But I will increase it to like 3 or 4 and scale appropriately.

The colors and fonts tips are invaluable. I'm not a designer but I definitely need to learn some fundamentals.

About vanilla vs frameworks, I really only pulled out Gatsby because we're switching to react at my job from angularjs and I wanted to practice with react syntax. But it definitely has been distracting as I've spent more time playing around with plugins and graphql than actual building :/

The css classname thing. Why would that cause a conflict if I name classes uppercase? The uppercase thing is a convention I saw in a react course for assigning a class to a component via css modules. But I do believe I broke the convention and was naming non component-container elements with a capital as well.

Rems vs ems vs px are fine to mix and match in the right situations no?

Thanks a ton for the in depth response. This is turning into a great learning experience.