DEV Community

Discussion on: What should and shouldn't be handled with Reader

molok profile image
Alessio Bolognino

interesting point of view, but your second code snippet could benefit from being a little bit more complete: there is no implementation and no return type of getDocsByRole and getDocsByRoles

fes300 profile image
Federico Sordillo Author

hi Alessio, thank you very much for your comment :)

this is not the first time I got this feedback so I added some type annotations and part of a possible implementation.
When I wrote the article I really wanted it to keep it as simple as possible as the point I am making is not technical, but apparently it was not the best idea