DEV Community

Discussion on: Project 11 of 100 - React Weather App

Collapse
 
nateosterfeld profile image
Nate Osterfeld

Hey! Know you're just trying to crank these out, but I gave your app a quick test run on my phone (Pixel 2 XL) and if you're looking for any points of improvement, I'd just say consider adding in routing so you can bookmark certain cities and navigate in general.

Also, it has me incorrectly show up as New York by default, not sure if you're aware.

Lastly, the city names weren't exactly responsive. Don't wanna give away too much personal info, but Cincinnati kinda went off the screen.

Other than that I think it's a really good day's work! Congrats and keep it up :)

Collapse
 
jameshubert_com profile image
James Hubert

Thanks very much Nate, you taking the time to comment means a lot.
Yeah- the site is not mobile responsive. The reason being that would just involve a bunch of extra CSS styling that I already know how to do and CSS isn’t the focus of my challenge even though it sadly means results are imperfect.
And yes New York is the default city. Auto-detecting location would be a fantastic addition though- any thoughts on how? I know you can request it through the browser.
Bookmarks are also an excellent idea. I’ll probably start consistently adding back ends with Node and Mongo next week :)