Thanks for the great article! I forwarded this on to my assistant lead devs. We can especially take the "break the build" approach because of our setup. Unreviewed code is sent for pre-commit code review on Phabricator Differential, and this triggers a Jenkins build on that revision. This means that the build can completely break without ever touching master or stable, and thus, without incurring the disasters that typically come with breaking the build.
Focused on creating wonderful user experiences by attending to folks needs with empathy and creating spaces of safety. Senior Frontend Developer/Tech Lead at Dolittle.
Really appreciate you taking the time to read an share this article, Jason!
In the wake of this and my previous article on shaming, I'm hearing more and more people share the value of pre-merge builds. It's not something I have any experience with, but it sounds to me like a really good approach. Removing the source of pain allows for a much more lenient and attitude towards when the build actually breaks.
Never knew of the Phabricator Differential (quite a mouthful), will look into that some time :).
Thanks for the great article! I forwarded this on to my assistant lead devs. We can especially take the "break the build" approach because of our setup. Unreviewed code is sent for pre-commit code review on Phabricator Differential, and this triggers a Jenkins build on that revision. This means that the build can completely break without ever touching
masterorstable, and thus, without incurring the disasters that typically come with breaking the build.Really appreciate you taking the time to read an share this article, Jason!
In the wake of this and my previous article on shaming, I'm hearing more and more people share the value of pre-merge builds. It's not something I have any experience with, but it sounds to me like a really good approach. Removing the source of pain allows for a much more lenient and attitude towards when the build actually breaks.
Never knew of the Phabricator Differential (quite a mouthful), will look into that some time :).
I recommend Anthony Shaw's write-up for how to do this on GitHub, if you or anyone else is interested: hackernoon.com/no-more-siren-of-sh...