Discussion on: How would you refactor this JS function?

View post

Replies for: Interesting function. I would need to have a closer look at the rest of the code to see whether refactoring this specific function is really the be...

There is a small bug in your last solution

const isEmpty = (line) => line !== '' && line != null;

returns false when line = "" and true when line = "test"

possible solution

const isEmpty = (line) => !line && line !== 0;
const isFirstLine = (index) => !index;
const getElementTag = (index) => (isFirstLine(index) ? "h1" : "p");
const getText = (line, index) => {
    const elementTag = getElementTag(index);
    const text = `<${elementTag}>${line}</${elementTag}>`;
    return text;
};
const br = () => "<br />";
const lineChecker = (line = "", index) => {
    if (isEmpty(line)) return br();

    return getText(line, index);
};

const checkLines = (lines = []) => lines.map(lineChecker);