loading...

re: I made over 1,000 code reviews - this is what I learned VIEW POST

FULL DISCUSSION
 

I can confirm from my experience that those are really important points! Thanks for the article.

A have a concern to add to the point "Sit with the author to review the code". I need some time alone for every PR. With just few exceptions. I need some time to go over the code line by line, mark conspicuous parts, and check them. This may take more than 30 minutes for many pull requests because I really make sure to check everything. I already found many important bugs like this. If the author is sitting next to me for the whole time, it may be boring for him/her. And I feel under time pressure.

Nevertheless, I find this is a good point and I will try to sit more together with the author.

 

Thanks for your input. I agree that you need to have deep concentration to fully review code

code of conduct - report abuse