re: Improve Your Code Reviews: The "No BS" Guide to Being a Dev with a BFA VIEW POST

FULL DISCUSSION
 

Could you share an example line or snippet that your co-worker who leaves the comments about the indentation gives the πŸ‘πŸ»on?

I'm known as the most thorough and strict code reviewer here and while I want to for sure start adding more compliments or calling out good things I have a tough time not just kind of assuming, "If I didn't comment on it, it's good." and leaving it at that.

I agree the shit sandwich is insincere and so I don't like doing it but I still would like to add more positivity. I realize that its proprietary code even if its just a snippet so if you can't share I understand.

Very nice article though! Thanks for sharing!

 

Yeah, I can't share actual lines of code, but I can give some examples. A lot of times the πŸ‘πŸ» is for refactoring, where the new code is a significant improvement over what was there before. Writing good tests often gets a πŸ‘πŸ», since we've all been working on that as a team. We've also been building our UI component library, so when we have the opportunity to include or create a new component, that gets a πŸ‘πŸ». Ditto re: adding useful comments on complex code.

Personally, if I see anything that makes me think "that was a good way to tackle that" or "glad we finally have that sorted out," I try to say as much to the person who coded it.

In a more general way, we also have a #shoutouts channel in Slack, where we are encouraged to call out someone who's had a "win" recently – not limited to code they've written, but for any work they've done. if you're feel like PRs aren't a natural place for you to add positivity, something like that may be a good way to accomplish something similar.

code of conduct - report abuse