DEV Community

Discussion on: Mastering Hard Parts of JavaScript: Callbacks IV

View post
Collapse
 
sarratas profile image
Sarratas • • Edited

Hi,

Your solution for exercise 20 is not really correct. It works for provided functions and inputs, but won't work for situations where, for example, first function appends something to the string. It also assumes that parameters are strings.

Example where it will fail (return ssss):

const addS = (str) => str + 's';
const addLowerCase = (str) => str + str.toLowerCase();
const repeat = (str) => str + str;
const capAddlowRepeat = [addS, addLowerCase, repeat];
console.log(pipe(capAddlowRepeat, "cat"));
Enter fullscreen mode Exit fullscreen mode

I believe more complete and actually also simpler solution is to correctly use initial value of reduce, like below:

function pipe(callbacks, value) {
  return callbacks.reduce((accum, cb) => cb(accum), value);
}
Enter fullscreen mode Exit fullscreen mode

Cheers!

Collapse
 
ramn_ruiz_dev profile image
Ramón Ruiz •

Great! I was going to comment the same. it seems much more correct answer. This way you are not limiting to string pipe. Value can be whathever the first function recieves as argument.