Discussion on: FactoryBot .find_or_create_by

View post

Hi !
Thanks for the article, nevertheless, it is working great when you don't have any other attributes in your object that needs to be validated.

I made a little git project to illustrate : github.com/ShamoX/country_test

commit: fd40c203 show the introduction of the problem.

Adding the new attribute here in the find_or_create_by doesn't work because we want inhabitants number to be random.

My solution then consist to first have to look for an existing entry only on the unique field, and then return the old record with it's own value...

What do you think ?

Joey Cheng • Mar 21 '20 • Edited

Hey Roland!

Firstly, apologies for the late reply. 🙏🏻
I'm happy that the article helped you!

If I understand your requirements correctly - you want to be able to find_by "country code", but create with random "inhabitants". Something lesser known in Rails - there is a method exactly just for that:

FactoryBot.define do
  factory :country do
    name { 'Canada' }
    code { 'CA' }
    inhabitants { SecureRandom.rand(10..100_000_000) }

    to_create do |instance|
      instance.id = Country.create_with(name: instance.name, inhabitants: instance.inhabitants)
                           .find_or_create_by!(code: instance.code)
                           .id
      instance.reload
    end
  end
end

This would find_by "code", and return if exists. Else, it will create with "code", along with "name" and "inhabitants".

I wrote that off the top of my mind. Can you test to make sure it works?

Alexey Grinko • Jun 5 '20

I solved it a bit differently:

  instance.id = Country.where(code: instance.code).first_or_create(instance.attributes).id

Not sure if it makes any difference with your sample above, but using instance.attributes makes it more generic as we don't have to explicitly mention each attribute.

Joey Cheng • Jun 6 '20

That’s neat! Yeah, this does seem simpler. Off the top of my head, I can’t think of any differences.