Peter,
This morning I've made an attempt at your test.
Currently I'm doing a Computer Science degree and only did OOP and Java in one module. Along with a bit of OOP in PHP.
As I've never developed in a commercial environment, I haven't come across Maven or Spring.
Overall I struggled more with Github than I did with Java.
It took me less than 1 hour, so I'm not sure if I missed anything?
Peter is the former President of the New Zealand Open Source Society. He is currently working on Business Workflow Automation, and is the core maintainer for Gravity Workflow a GPL workflow engine.
Hi Simon, congratulations on completing the task as written.
Take another look at the code with the eyes of a code reviewer. Ask yourself how you might improve or refactor the code base while introducing the new functionality. If you do make improvements note down what the changes are and how they make the code better, but keep them to yourself for now.
Next week when I publish my solution I plan to have a discussion about the different approaches people took.
Peter,
This morning I've made an attempt at your test.
Currently I'm doing a Computer Science degree and only did OOP and Java in one module. Along with a bit of OOP in PHP.
As I've never developed in a commercial environment, I haven't come across Maven or Spring.
Overall I struggled more with Github than I did with Java.
It took me less than 1 hour, so I'm not sure if I missed anything?
My attempt is at
I look forward to some feedback.
Thanks,
Simon
Hi Simon, congratulations on completing the task as written.
Take another look at the code with the eyes of a code reviewer. Ask yourself how you might improve or refactor the code base while introducing the new functionality. If you do make improvements note down what the changes are and how they make the code better, but keep them to yourself for now.
Next week when I publish my solution I plan to have a discussion about the different approaches people took.
Thank you Peter.
I did see quite a few changes that could be made.
I've removed the link from my post, until other people have had a go.