Discussion on: How do you code review?

[Sean Allin Newell]

My suggestion for a thorough code review of any given PR/MR would be:

• read the ticket if any (get as much context before reviewing)
• read through the commit messages (this is the code's story)
• pull the code locally and run the new code
• run the tests
• look at the full diff quickly
• look at each file changed carefully
• ask yourself these questions:
  • can this PR be broken up into smaller ones?
  • how can this be made more maintainable?
  • how can we increase test value/coverage?
  • are there any edge cases?
  • did we forget any requirements?
  • does this make the system harder to run locally?
• call out things in the PR that are praiseworthy #encouragement
• bring others into the PR to brag on what you see or call in extra help/experts.

Some of this can be done quickly for small PRs, other times you may need to do 5-15min spurts of review as you have time.

Then approve and merge that sucker in!