loading...

re: I made over 1,000 code reviews - this is what I learned VIEW POST

TOP OF THREAD FULL DISCUSSION
re: Ideally, the feature would be small enough to make for a reasonable PR. Breaking up the PR would split the context - it's hard to see the big pictu...
 

Thanks for reply! Sure, feature slicing is always a good idea but I am talking about situations when feature cannot be further sliced down.

Yeah, then it's better to have it as one PR. What helps me the most then is to sit with the author and speak my thoughts out loud. It makes the process go faster

code of conduct - report abuse