Reviewer just try to show how smart they is - look how much smart words I know "dependency injection", "services".
You got task. You implemented it. You have e2e tests. It is a good solution for the given task (I would also test gibberish input and negatives).
Some people just can't handle simple solutions.
Once a programmer becomes used to a complex solution to a problem, simple solutions to the same problem feel incomplete and uncomfortable. — Doug Hoyte
Once a programmer becomes used to a complex solution to a problem, simple solutions to the same problem feel incomplete and uncomfortable.
— Doug Hoyte
Thank you.
P.S.: Yes, I forgot about negatives and gibberish input, indeed.
Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment's permalink.
Hide child comments as well
Confirm
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Reviewer just try to show how smart they is - look how much smart words I know "dependency injection", "services".
You got task. You implemented it. You have e2e tests. It is a good solution for the given task (I would also test gibberish input and negatives).
Some people just can't handle simple solutions.
Thank you.
P.S.: Yes, I forgot about negatives and gibberish input, indeed.