DEV Community

Discussion on: I made a portfolio! Feedbacks are welcome

Collapse
 
tomekbuszewski profile image
Tomek Buszewski

Hey Amine,

That looks pretty good!

Here's my couple of cents:

  • your "logo" looks like a placeholder (maybe it is?);
  • two different font-sizes in the nav – it kinda looks like you applied the style only to "contact". If you want to make it stand out, think about coloring or bolding, but right now it doesn't really look that good;
  • I'd say it's a bit text-heavy, you have a good typography but you overuse it. I don't think "projects" section is benefitting from all this text. A screenshot would be better;
  • on a tablet two columns are cramped, one would be better;
  • no real footer.

Also, always when I go back from blog, I see the "loader" (three bars fading and going down). Try to think of something that'll check if the user comes from someplace else and show the loader only then.

Those are my thoughts. All these things are super minor. You did a great job and I am looking forward to seeing your next projects!

Collapse
 
aminejvm profile image
Amine

Without the logo it the navbar feels empty, so I figured out a little circle would balance it. Yes, I fixed the button font to match the resume and blog link.

I'll make sure to redesign the projects section the way Madza explained and maybe I'll add a footer.
And thank you for noticing the loader bug, I'll make sure to fix it. Thank you, sir!

Collapse
 
tomekbuszewski profile image
Tomek Buszewski

Hey, maybe you should really have a logo? Like I've said, circle feels very generic.