DEV Community

Discussion on: How to deal with an argumentative code review?

Collapse
 
tomfors profile image
TomFors

If you are managing her, you should consider pulling her aside at a time when no one is upset and explain the situation and concerns. Go over how code review is supposed to work. Make it clear that her attitude towards it needs improvement and that the goal of the review is to improve the code quality before it gets merged, not to blame or argue. Don’t make this a disciplinary meeting - it should always be clear what is expected before something like that happens.

You might want to consider having her do code reviews for yourself or others, or sit in on code reviews with others for her to see what’s expected.

Collapse
 
190245 profile image
Dave

Thanks for the reply, Tom.

While technically she doesn't report directly to me, the Dev Manager is the completely hands off type (which I prefer) and so it likely does fall on me to organise a quiet face to face. Thankfully, as she's not a direct report, it can't possibly be taken as a disciplinary either.

There's also things going on in the background that I won't detail (HR/medical issues), so I've been a little reluctant to take the bull by the horns on this issue.

However, my post was written while I was on vacation (lots of time for reflection on the beach...). I've come back & so far taken the "God Complex" approach of "you're a junior, I'm a senior, I have spoken & this is my reasons. Do as instructed."

I've only done that where I felt things were descending into a debate too much, and so far, HR haven't flagged anything in my direction. Hopefully once a trend sets in, I'll be able to back off a bit.