DEV Community

Discussion on: A Clear, Concise & Comfy Code Review Checklist

Collapse
 
worc profile image
worc

i'd definitely double underline the caution in the Code Duplication item. i've seen dry turn pathological.

pushing or encouraging deduping too strongly leads you away from small, simple changes--hey i copied a line from one service into another--and into a cascading cluster of refactoring and renaming and rethinking--hey... so i spent the last week completely redesigning the system and now every basic equality check or destructuring statement is separated out into one of a dozen "helper" files and each concrete step of each procedure is abstracted away behind at least three levels of indirection, but hey at least we aren't repeating ourselves!

i'd rather get the functionality in first and then start a second, new task looking into that possible deduping. sometimes it makes sense, and sometimes you're just making contrived abstractions that will hurt to maintain later.

Collapse
 
chris_bertrand profile image
Chris Bertrand • Edited

Thanks for the comment, I completely agree and have amended the article. People love to refactor once a feature is complete. That basically negates the benefits, unless you know that this is going to be touched again shortly!

P.S - Underlines are not supported in Markdown, let also double underlines! But I've chucked it in a blockquote! 😁