A change you approved last week has caused a problem in production. Nothing dramatic, but real. The author is already fixing it, and you sit rereading your own comment from Tuesday. Looks good to me.
It is tempting to leave this entirely with the author. Their code, their bug. But your approval was part of the process too, and this is the clearest feedback you will ever get on how you review. Most of the time reviewers never find out what they missed. Today you have.
Start by reopening the change, privately, and reading it again knowing what went wrong. Then ask yourself one honest question. What would I have needed to notice? Sometimes the answer is that nothing in the diff showed it, because the problem lived in code that did not change. Sometimes it was right there on line forty, and you skimmed it because the author is careful and it was nearly five o'clock.
Write that answer down in a sentence. I approved without checking what happens when the list is empty. I read the code but never ran it. I did not look at what calls this function. Patterns appear quickly once you have three or four of these sentences, and they show you exactly where your attention goes missing.
Say something to the author. Not an apology tour, one line. I approved this and missed it too, happy to look at the fix with you. It matters to the person who is feeling it most, and it shows the team that review is shared ownership rather than a rubber stamp.
Then change one habit, not ten. If you keep missing empty cases, start every review by asking what happens with nothing. If you skim when tired, stop reviewing late in the afternoon, or say so and hand it to someone else. One habit you actually keep beats a long checklist you abandon by Thursday.
Be fair with yourself as well. Review catches a lot but never everything, and a reviewer who expects perfection soon becomes slow and nitpicking. The aim is not to never miss anything. It is to miss a different thing next time.
Every bug that gets past you is a small, free lesson in reviewing. Take it.
– Asael Shinder
Top comments (0)