if you want to make a PR to provide a better path towards our ideal state with themes, go for it. Or we can chat more in the issue. We may want to tweak this approach a bit but I wanted to get something out there as a tangible proof of concept and some momentum in this direction.
I'm about to be busy for a while, starting a new job (very exciting), but I think more discussion is needed. I don't know much about the backend so would need to hear from some people with some ideas on how to do it there. @rhymes
As for the front end simply having a style block at the top of the body with the correct style information would be enough.
--theme-container-border: 1px solid #141d26;
Provided that doesn't run into the caching issue.
Putting that directly into the HTML wouldn't work per se, but along the lines of my initial implementation, this should work if done along the lines of how this has been implemented.
How this currently works:
Currently I quick-and-dirty did it via the body class. I should have waited but I was pretty excited to get something out and I was slightly confused about this part but have more clarity now. I'll modify this to use :root and explain how it's done.
I'll make a detailed DEV post once this is in place.
And congrats on the new job Andrew!
Another question we need to ask is will users be able to set all the variables themselves or just have a few premade themes to choose from?
There are bits that won't look quite right with this implementation but if people raise issues saying, 'this bit looks off', it will be easy enough to track down the style and sort it.
Thank you, it's my first 'real' development job, better late than never 😀
I think we can build towards letting folks set their own variables, but let's start by collectively working towards a shared concept of night mode and open things up once we've crossed that bridge.
A full fledged theme editor! DEV brings back Myspace 🤣
Is the dark theme somewhere on github, so I can edit it?
Oh, found it
We’re a place where coders share, stay up-to-date and grow their careers.
We strive for transparency and don't collect excess data.