That is a really great list of recommendations!
Thanks for sharing.
What I would like to add: reviewers should have enough experience in both tech and business domains. This way a code review would be more efficient for detecting tricky issues.
Organizations
p.1 - it is really hard to achieve this. I tried many times as a team lead to engage people, but simply most people don't like to look at others code. Or just don't have a time to do that because of a rush in development.
Reviewers
p.7 - in our teams we could accept PR without tests first to check if initial implementation is done in a proper architectural style.
Again, thanks for sharing!
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
That is a really great list of recommendations!
Thanks for sharing.
What I would like to add: reviewers should have enough experience in both tech and business domains. This way a code review would be more efficient for detecting tricky issues.
Organizations
p.1 - it is really hard to achieve this. I tried many times as a team lead to engage people, but simply most people don't like to look at others code. Or just don't have a time to do that because of a rush in development.
Reviewers
p.7 - in our teams we could accept PR without tests first to check if initial implementation is done in a proper architectural style.
Again, thanks for sharing!