DEV Community

Discussion on: DEV Went Open Source One Year Ago Today, And We Have So Much More Planned!

Collapse
 
link2twenty profile image
Andrew Bone • Edited

A whole year, wow, doesn't time fly!

EDIT:

I like @rhymes idea of showing first pull requests!

My first pull request was to move the menu down by 8 pixels, just to test the waters.

Move menu background down 8 pixels #1227

Description

Move menu background down 8 pixels to prevent seemingly random bumps.

I probably ought to have left this for someone as a first PR but it bugs me πŸ˜‰

Related Tickets & Documents

#1160 #1213

Added to documentation?

  • [ ] docs.dev.to
  • [ ] readme
  • [x] no documentation needed

But I'm most proud of implementing CSS variables, something @ben took a chance on and let me implement.

The wonder of having a community like this is how quickly the CSS variables evolved, thanks to people adding to them and finding places I'd missed.
This allowed for multiple themes to be created.

Beginning of css variable implementation (--theme-background) #1306

What type of PR is this? (check all applicable)

  • [ ] Refactor
  • [x] Feature
  • [ ] Bug Fix
  • [ ] Documentation Update

Description

Added --theme-background leaving the default the same. This will make no, visible, change to the styles currently.

Adding CSS variables means loading a CSS file containing overrides means you can change the whole sites theme.

:root {
  --theme-background: #303030
}

Related Tickets & Documents

#1104 and #1377

Added to documentation?

  • [ ] docs.dev.to
  • [ ] readme
  • [x] no documentation needed

β€οΈπŸ§‘πŸ’›πŸ’šπŸ’™πŸ’œπŸ€ŽπŸ€

Collapse
 
rhymes profile image
rhymes

That was great work Andrew!

Collapse
 
ben profile image
Ben Halpern

Yes! And thank goodness for your awesome ideas and contributions in getting themes going with variables, among other great CSS contributions. It's been such a boon to our frontend efforts.