Before I ask for a review on a PR, I make sure that my code is production-ready and fully reviewed by me. I developed this mindset by having to rev...
For further actions, you may consider blocking this person and/or reporting abuse
This is a really interesting and I think important point. I always try to review my own work, but normally within my IDE.
Conducting a review as if it was someone else's code, within your favourite code review tool should give you an outsider's perspective on your work. I am going to adopt this approach going forward.
Thanks Shalanah :)
Great post, Shalanah!
Most of this is my personal practice, even on my side / learning projects. I've chatted with other team-mates about it as well; our current project tries to self-review before requesting a code review.
p.s. - do I see a future lightning talk at JS MN? π
I think this is important and also why I recommend cleaning up history to
Partnered Code Reviews
Jesse Phillips γ» Feb 13 γ» 1 min read