This is my first blog for release 0.1. The project that I worked on was the telescope Project which is Seneca college open source Project. I found one issue for the project and started to work on it. The issue was about customizing the dashboard so it looks like it belongs to Telescope. And in the issue, I need to change:
- use the Telescope logo
- use the Telescope favicon
- Change "Material Dashboard 2" to "Telescope Dashboard"
- Get rid of the "Upgrade to Pro" button
- Get rid of copyright and other links in the footer
- Change the primary color from reddish/purple to use the primary Telescope color
This is the previous version that I changed.
I fixed those criteria and Created a pull request.
And this is the screenshot of when the pull request was created.
After that, I got lots of comments and I keep doing the cycle of check comments, editing code based on the comments, and pushing it to the github until there are no comments left.
And this is the final result after it merged.
This Pull request was the most active PR ever I had in this course. After I the Pull request was merged. the number of comments in this PR was 58. It was hard for me. because I usually, if I create a pull request, there were some comments are there and in next 2~3 new commits make the pr merged to the program. However, this one takes more time than usual. Even though it was a long process. it was very helpful to me to experience active code review on my code.
While I am working on this issue, there was a person who created the same change requests which are already discussed in previous comments. There was one person who commented on the same thing which was already discussed above. Before, when I write comments on the other's pr I usually read the previous comments but not always. Maybe for him, it was a few comments that he put on a random pull request, but for me, it was a pr that I working on. And it takes my extra time to explain to him to look at the discussion above. For next time, I think I will carefully read the previous comments every time on the other's pr when I want to add new comments to prevent double work which is unnecessary.
But most of the comments were very useful and most of the comments were about the side menu bar. There were comments that ask me to add and remove the item, remove the scroll bar, change the icon and color of the active tab. To be honest, while I am working on it I felt like its too much work for a single issue. But, after I finished everything and look at the result. It was very satisfying to me.
Top comments (0)