This post is not about how to write a good pull-request, for there is a lot of great material about that in this blog and also online. Instead, thi...
For further actions, you may consider blocking this person and/or reporting abuse
Nice post! Those are very good points.
At Airtasker we found Conventional Comments to be very useful.
The idea is that you set the expectation around the comment before the comment. So it avoids a lot of assumptions on both parts of the reviewing process.
Everyone states clearly the objective of the comment, but also its urgency.
Your examples could look like:
We do not follow it strictly, but just by using some of its concepts improved a lot the quality of our reviews and also the empathy on both sides.
Thanks for sharing Rafael! I will definitely use this for future reference.
Nice post! I like the approach of asking a lot of questions and have used that in my code reviews too. One counterpoint is that on teams with high levels of trust I would rather have the first example of PR comments. For example I would much rather someone say "m is not a good name for a variable, you should name it message" rather than coming over and having a side discussion on it. If I disagree, I can comment back and then other on the team can chime in.
Good sharing, every developer should read
Recently started working with PRs and I think this will be super useful!! Thanks for your post, Tan 👌🏻👌🏻
Thank you! Glad you liked it.
Hope you have a good time reviewing those.
Kind regards!
Those are very useful points! Sometimes it's just hard to keep the comments nice, and these are good tricks :)