Starting the third week of OSD600 and we find out that this time, it is not just overlooking someone else's code, but actually modifying it as well as adding some features. What we have to do during this lab is modify the file, so it is able to convert md file to html file as well. Also, we need to add one more feature for the md file conversion. It's more like a lab for us to help improve other people's program with actual code.
During this lab I managed to find a partner which was simple enough though there were some unexpected complications. When I was doing my lab someone else had already filed an issue on my repository. So minor complications but nothing that we couldn't work around.
During Contribution
The first step I did was I added an issue to Eakam's repository so that they knows what I'm doing with their code For this Lab 2, I'm going to implement the code that allows user covert a md file into a html file. Also, I would like add a feature that be able to change the header syntax (#) in an MD file into the <h1>random text</h1>.
I then forked the rost_gen repository and started modifying the code. Though it did take me a while, because I had trouble understanding how to properly run the command. This is my first time coding and using Rust While coding it I accidently coded it twice meaning that there was a double output. But I fixed the issue shortly after.
Being Contributed To
Maxim was the one to contribute to my code, and it was honestly not that bad. The first time I've ever had a pull request, and it look like it went well for them. It was relatively minor changes, after that there wasn't need for much change besides the filename as well as some parts of README.md. Though instead of using GitHub to ask for him to change, I connected with them through Slack to ask for those changes.
Thoughts
This was a relatively simple lab, that I had way too many issues with. This is due to the fact that this is the first time I have ever used Rust. This is the first time I have also created a pull request in order to modify someone else's code. It was an experience that was very welcome, and now is in my skill repertoire.
Link to my pull request: https://github.com/Eakam1007/rost_gen/pull/26
Link to the program I modified:https://github.com/Eakam1007/rost_gen
Link to pull request to my repo: https://github.com/LostButton/my-button-ssg/pull/7
Link to my repo: https://github.com/LostButton/my-button-ssg
Top comments (0)