It’s not a fully “programming” concept but pull request on Github sounds weird for me
so true, i couldn't agree more
I 100% agree, GitLab calls them Merge Requests which is more accurate
Exactly! and you aren't really requesting to pull anything, if anything you are requesting to push something. Merge request sounds better but at the same time I've gotten so used to pull request even though it makes no sense
I guess it’s a request that the other person pull, right? But either way, merge request 100% better.
Oh truue, I didn't think about that. It's like a "hey i did a thing, can you please pull this into master?"
Still totally weird. I had the same confusion when first introduced.
I asked myself the same thing a while ago, and I found a good explanation on SO which links to a GitLab's article that debates about this topic.
Think GitHub's feature name comes from git request-pull. Both are completed by the receiver rather than the author, so it's kind of pulling, even though it's a merge still...
But git pull is also git fetch && git merge FETCH_HEAD, so who knows...?
git fetch && git merge FETCH_HEAD
I guess GitLab's name for it does make more sense for the resulting action though.
One should always remember, Github created this workflow idea for mainstream. I'm curious if request-pull actually came after github.
I don't have a memory of the early days, but I expect the merge feature was not in the initial UI, meaning you literally asked the person to run git pull on your branch i.e. fetch and merge.
From my estimation, pull-request came from the author imposing his viewpoint on others. He assumed that he would be in control of the upstream repository and named it as a hybrid of what it was to him and what he had to do with it.
A better approach is to consider the user's point of view.
Git is a mess of badly structured commands, but a useful tool. Look at mercurial of you want an example of git workflows with a better command line interface.
You'll need to help me on this one. What does hg call it?
"Create a "Pull request" on data in the repo"
Don't bother looking at Mercurial if you're a BitBucket user though:
ha haaa ... Form the beginning this sounds wired for me also
You're requesting somebody to pull in a branch from your fork of the repo. The exact operation when using Git in the command line that merging the request equates to is git pull not git merge, so Pull Request is technically correct.
We're a place where coders share, stay up-to-date and grow their careers.
We strive for transparency and don't collect excess data.