Disclosure: This draft was generated with AI and checked against the cited primary sources, with a separate AI editorial review. It was prepared for the FrameSprite team, which has a commercial interest in FrameSprite. Proposed examples are not executed tests unless explicitly identified as recorded fixture results.
Approve the commit that contains the reviewed sprite, not just the pull request title. If an artist replaces a texture or its timing metadata after approval, the earlier review is evidence about the earlier version. Request another review of the changed delivery files before merging.
Key Takeaways
- Record the reviewed commit and the exact asset paths.
- Recheck visual output when pixels, layout, or playback metadata changes.
- Keep approval separate from a successful import or build.
Why the green approval can become misleading
A sprite pull request can contain several exports over its lifetime. A reviewer may approve a blue sword silhouette on Monday, while Tuesday's export changes the grip and frame order. The conversation still looks positive, but it no longer describes the delivery candidate.
GitHub offers options for dismissing stale approvals and requiring review of the latest push. These are configurable protections, not evidence that a particular repository has enabled them. Check the actual settings and bypass rules with the repository owner.
Bind the review to a small, explicit asset set
Start the review message with the commit identifier, texture paths, sidecar paths, and preview generation method. A contact sheet attached to a comment should state which commit produced it. A screenshot uploaded before the final export needs replacement or an explicit historical label.
Use the Git diff documentation to select the comparison you intend: the proposed branch against its base is different from unstaged local changes. Have the reviewer inspect the candidate export, not an editor tab that might contain uncommitted work.
Classify later changes by consequence. A spelling correction in a README may need editorial review. Changing cell dimensions, action names, frame duration, or attachment positions needs the relevant visual or integration reviewer again. Do not decide that a JSON edit is harmless merely because the PNG did not change.
A concrete review sequence
Suppose commit art-a contains guard/attack.png and an eight-frame timing file. The artist receives approval, then exports six frames at commit art-b to improve the hit pose. The preview in the original comment still shows eight frames.
The next review should identify the removed poses, inspect the six-frame sequence, and confirm that timing and any event references match it. Upload the new preview with art-b in its caption. Keep the earlier discussion as context rather than silently replacing the candidate and assuming approval transfers.
If the change only renames an internal file, verify all consumers before treating it as administrative. A resource reference can break while its image remains visually identical.
Ownership and acceptance
CODEOWNERS can route review requests, but routing does not prove that both the art and importer contracts were checked. Name those responsibilities in the pull request when one person cannot cover both.
Accept the revision when the review record identifies the final commit, the preview matches that revision, all changed sidecars are included, and required reviewers have approved the actual candidate. A passing build answers a different question: whether the files could be processed.
This is a proposed review procedure derived from documented version-control behavior. No repository settings, review turnaround, or defect reduction were measured for this example.
Continue the workflow
Use the Is a GIF preview enough for a teammate to approve a sprite animation? for the neighboring problem. Keep the animation handoff checklist with the delivered package, and preserve its visual decisions in the game-art reference board.
Sources and editorial responsibility
Prepared by the FrameSprite Workflow Team. See the editorial method or contact the team with a reproducible correction. Sources checked 2026-10-20.
Top comments (0)