Hey everyone!
I’ve recently completed a Tetris game and am currently focusing on refining some parts of the code. I would be grateful for any general coding advice and feedback on how to improve the structure and readability of my code.
In particular, I’ve been concerned about these specific areas:
Functions in the conflict_resolution.c module:
- The functions
side_cells_crossing_prevention,side_boundaries_crossing_,bottom_top_boundaries_crossing_of theconflict_resolution.cmodule don't seem to be clean and easy to read code. They used to be a single function. Is there a better way to structure these functions for clarity and maintainability?
Duplicated logic in the conflict_resolution.c module:
- The
conflict_resolution.cmodule has the functionstop_center_conflict,top_right_corner_conflict,right_center_conflict,bottom_right_corner_conflict,bottom_center_conflict,bottom_left_corner_conflict,left_center_conflictandtop_left_corner_conflictthat seem to have quite a bit of duplicated logic. Additionally, thehandle_top_center_conflict,handle_right_center_conflict,handle_bottom_center_conflict,handle_left_center_conflictfunctions could probably be refactored to reduce repetition. Any advice on how to better consolidate these would be really appreciated!
Here's the link to the full code: https://github.com/FyodorPotseluev/tetris.
You're welcome to join the "Discussions" section of the repository.
Any thoughts or suggestions would be super helpful!
Top comments (0)