DEV Community

Discussion on: React: Class Component VS Function Component with Hooks

Collapse
 
adjsays profile image
Andrew Johns

New to React (I've only read about it) so I may be wrong (and if I am, I'd like to know why) but I don't think you need the changeTime function in your hooks example, you can call setTime directly which would reduce it even further. Is it just a question of code style?

useEffect(() => {
const tick = setInterval(() => {
setTime(new Date())
}, 1000)
return () => clearInterval(tick)
})

Collapse
 
brunofunnie profile image
Bruno de Oliveira

It's good practice to decouple your code

Collapse
 
devesh198 profile image
Devesh Gupta

If setTime() is added to useEffect() then it'll have to be added as a dependence also. This could trigger useEffect many times if setTime() is used else where and create an endless loop.