DEV Community

Discussion on: How to Give Better Code Reviews

Collapse
 
aminmansuri profile image
hidden_dude

Definitely more about design and architectural choices than linting or formatting.

For example a couple of times I've seen people using the wrong data structure which made the code complex and maybe even unsolvable (and definitely full of errors). Other times the code wasn't following the approach that was discussed, so getting into the reasons for that is also useful.

Collapse
 
aminmansuri profile image
hidden_dude

It's also useful if developing code is an ongoing conversation.

You discuss what design to choose, what approaches to take, then people go off and do it, then the code review is just a continuation of the discussion and a test to see in what ways those approaches succeeded or failed.