DEV Community

Discussion on: Can you find the bug in this piece of php code? 🤹

Collapse
 
arxeiss profile image
Pavel Kutáč

Yeah, the issue is with != operator. And that is the reason I'm using strict rules for PHP CodeSniffer. It is based on Slevomat rules and my setting is here github.com/arxeiss/php-coding-stan...

The important one to avoid those issues is this rule

<!-- Disallow use == or != and must use === and !== -->
<rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators"/>
Enter fullscreen mode Exit fullscreen mode
Thread Thread
 
nombrekeff profile image
Keff

Nice that's it. Thanks for sharing your solution to the problem. Do you know if there is something similar to run on CI/CD? or would that just work fine? (I'm not a php dev so I don't know how this works in detail)

Thread Thread
 
arxeiss profile image
Pavel Kutáč

I'm running this in CI/CD. Basically you

  1. Install PHP CodeSniffer github.com/squizlabs/PHP_CodeSniffer with composer require --dev squizlabs/php_codesniffer or composer require --dev arxeiss/coding-standards to install directly my prepared set of rules.
  2. Prepare your own XML config, sample one is in my repo above too
  3. And then just run ./vendor/bin/phpcs --standard=./phpcs.xml
Thread Thread
 
nombrekeff profile image
Keff

Fantastic easy enough, thanks a lot for the info.