DEV Community

Discussion on: Why code review is an underrated skill in testing

Collapse
 
eljayadobe profile image
Eljay-Adobe

In my experience, and in a white paper on code reviews from Microsoft, the problem with code reviews is that they tend to be gloss level.

Small code changes that have changes that are self-contained / local to that part of the code can be code reviewed effectively.

Large changes (100+ line changes) across many files tends to be overwhelming on the code reviewers, and the quality of the review goes way down, and the reviewers tend to comment on inconsequentials like indentation or typos in comments, rather than structural, how the behavior changes, and interactions.

Code reviewers that are intimately familiar with the code being changed can have a much more in depth and meaningful reviews. But even original authors who have been out of that code for a while will have less effective code reviews.

The best code reviews are pair programming or mob programming, which the code changes are undergoing immediate and interactive continuous code reviews (CCR). But unless a team is doing something like Extreme Programming, they probably are not engaged with pair programming or mob programming. CCR is the best bang-for-the-buck code review process.