You did a common mistake, to not hide the spinner at error, see promise.catch().
I know that error handling is a tabu subject in the JS ecosystem, but we should change this.
Didn’t know about promise.catch. I’ll check it out. Thanks!
At least use ".finally()" to hide spinner at the end of process. Indeed, ".then()" will never called on error and spinner will stay stuck.
Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment's permalink.
Hide child comments as well
Confirm
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
You did a common mistake, to not hide the spinner at error, see promise.catch().
I know that error handling is a tabu subject in the JS ecosystem, but we should change this.
Didn’t know about promise.catch. I’ll check it out. Thanks!
At least use ".finally()" to hide spinner at the end of process. Indeed, ".then()" will never called on error and spinner will stay stuck.