DEV Community

Discussion on: Do not use AndroidViewModel

Collapse
 
cbeyls profile image
Christophe Beyls

It's indeed a good practice to remove Context from all the public APIs of our components, at least to make them easier to test. However, internally at the bottom level, many components in an Android app always end up needing a Context because Android requires it for so many things: accessing a system service, starting a component, connecting to a MediaSession, connecting to the Firebase SDK, ... or just simply accessing the file system!

So let's take an example: you have a ViewModel that needs to call a repository that internally uses a Room database for storage. Room needs a Context to be initialized. If you're not using dependency injection (like many Android apps back in 2017) and you want to lazily initialize this repository the first time you access it, then you'll have no choice but to pass a Context to it. AndroidViewModel was created to provide the application Context for that usage, so you don't have to pass an Activity Context manually from the View layer and risk creating a leak.

Of course today using dependency injection is the recommended way and injecting components with the right Context into a ViewModel constructor is easy with a library like Dagger Hilt.

Thread Thread
 
devdalgic profile image
Denizhan Dalgıç

Now I get what you are saying. You're right, of course. I didn't mean to pass repository to ViewModel. That'd be chaos 😀

The main reason I've written this article is because you don't get any warnings in Android Studio when using AndroidViewModel, even though it is clearly said not to be used in documentation.

Google deprecates functions aggressively, and sometimes to "direct" people to use good practices. However, it seems that this doesn't apply to AndroidViewModel.