This is the process used at a previous job, not my current one. However I believe it was one of the best I have participated in, helped keep the quality of the code high, and created some great discussions and learning experiences for developers.
Once a story/feature/whatever is ready the developer working on the story creates the PR. They include reviewers from across teams, not necessarily across disciplines however. This may not be possible everywhere if the teams are structured differently, but basically getting 3-4 people on a PR was the goal.
The PR was announced in our chat, tagging the people who were requested to review. And generally a timeframe was given like, "Hey everyone, looking for feedback on story #1234. Hoping for final feedback by EoD Wednesday." Everyone then gives their feedback, and the developer responds with a change based on the comment, or a discussion why they won't/can't do things differently. If it's a quick conversation that would happen in the PR comments. Sometimes bigger discussions took place, but the PR comment was always addressed in one way or another.
Once everyone is satisfied their comments have been addressed, they sign off on the PR, and the developer is then ready to move along in the process to merge the story. The developer that completed the story is the one who ultimately did the merge.
For the most part the process worked really well. It can be a bit daunting at first, but I definitely learned a lot from those reviews. They're much more streamlined than a traditional, everyone in a room, go through code for stories, and review kind of process. They fit into the day much better as well.
This is the process used at a previous job, not my current one. However I believe it was one of the best I have participated in, helped keep the quality of the code high, and created some great discussions and learning experiences for developers.
Once a story/feature/whatever is ready the developer working on the story creates the PR. They include reviewers from across teams, not necessarily across disciplines however. This may not be possible everywhere if the teams are structured differently, but basically getting 3-4 people on a PR was the goal.
The PR was announced in our chat, tagging the people who were requested to review. And generally a timeframe was given like, "Hey everyone, looking for feedback on story #1234. Hoping for final feedback by EoD Wednesday." Everyone then gives their feedback, and the developer responds with a change based on the comment, or a discussion why they won't/can't do things differently. If it's a quick conversation that would happen in the PR comments. Sometimes bigger discussions took place, but the PR comment was always addressed in one way or another.
Once everyone is satisfied their comments have been addressed, they sign off on the PR, and the developer is then ready to move along in the process to merge the story. The developer that completed the story is the one who ultimately did the merge.
For the most part the process worked really well. It can be a bit daunting at first, but I definitely learned a lot from those reviews. They're much more streamlined than a traditional, everyone in a room, go through code for stories, and review kind of process. They fit into the day much better as well.
Giving a timeframe for the review is an excellent idea I will adapt right away!