re: Improve Your Code Reviews: The "No BS" Guide to Being a Dev with a BFA VIEW POST

FULL DISCUSSION
 

Great article, it really highlights the things people tend to overlook. I for one, thought shit-sandwiching was a good idea.

 

It's not the WORST thing you can do (it's definitely better than just being negative 100% of the time), but once you realize someone is doing it to you, you start to question whether the compliments are "real" or just something they said because they knew they had to find something to put on either side of the shit. Personally, I think it's better to just compliment and critique genuinely vs. feeling like you're obligated to make X compliments for every Y critiques.

code of conduct - report abuse