DEV Community

loading...

Discussion on: Clean up your code with these tips!

Collapse
dechamp profile image
DeChamp Author

Aw! you're so right! I should have used test vs match, also I should have added in $ for an exact match. I'll update this! Part of the fun was to show people they can resort to regex when doing multiple test against a single variable. If it was another scenario of checking the domain against lets say 3 or more possible values, then regex is a quick way to solve this.

Thank you for the great feed back.

Collapse
lexlohr profile image
Alex Lohr

You're welcome. I'm usually rather eager to solve things with regex myself. So I usually think again: "will a regex make that code better?" and try it without the regex. In ~50% of the cases, I keep the regex. For the sake of having an example, I feel it's justified. For live code, I would have removed it.

Thread Thread
dechamp profile image
DeChamp Author

I like your clear view on this. I agree that the regex is over kill when we are only checking two values.