DEV Community

Discussion on: I wrote a crawler for the first time.

Collapse
 
donal_tweets profile image
Info Comment hidden by post author - thread only visible in this permalink
Dónal

Tip, there's no point in in using a try-catch if you're just going to re-throw the error. In other words, this

try {
  doStuff()
} catch (err) {
  throw err
}
Enter fullscreen mode Exit fullscreen mode

is functionally identical to

doStuff()
Enter fullscreen mode Exit fullscreen mode
Collapse
 
kayla profile image
Kayla Sween

Tip, if you’re going to give unsolicited advice on someone’s code in a blog post, at least comment about the core of the post. Like, “hey great job! This is something you could do instead:” or “hey this blog sucked and here’s why:”

I see your account is brand new, so I’m hoping to help educate you on a little bit of etiquette in regards to constructive criticism. Hope that helps!

Collapse
 
donal_tweets profile image
Comment marked as low quality/non-constructive by the community. View Code of Conduct
Dónal

Well seeing as you asked, here's why this blog sucks:

A web crawler is not a technically challenging task. As we can see from the post above, it's just a combination of basic web programming steps such as making HTTP requests and HTML parsing.

That it took someone whose core competency is front-end development 9 years to tackle something so straightforward is fairly risible. I don't see how you can claim to be a "senior-ish" front-end engineer yet be apparently ignorant of core concepts such as error-handling and asynchronous programming.

Hope this helps!

Thread Thread
 
kayla profile image
Kayla Sween

Thanks for reading!

Some comments have been hidden by the post's author - find out more