DEV Community

Discussion on: Please be professional and stop saying "I'm almost done!"

Collapse
 
dvddpl profile image
Davide de Paolis

absolutely.
such a comment in a code review does not make much sense. And honestly i would take for granted that the reviewer knows really well the codebase (and has checkout out the branch to see the piece of code in its entirety and maybe try it out)

If the other way is just a matter of taste, it is bad, if it is indeed a better solution but not preventing major bugs or solving a problem that may arise, and you are already tight on the schedule , it can be better to leave it as it is, or maybe create an Issue on Github/Gitlab or a followup ticket that will be estimated and planned.