DEV Community

Discussion on: It's nice to be nice! - Code Reviews

Collapse
eaich profile image
Eddie

The worst I've seen is "Nope."

For me, code reviews with more junior developers usually turned into more of a training/mentoring session, which is perfectly fine and pays off in the long run. You just have to make time for it and not rush through it.

On the flip side, code reviews with more senior developers were really mostly dependent on their personality. I worked with a developer who was known to be very short and blunt. He would say things like "why you do this way?", which could seem off-putting at first, until you spend time with that person and just learn and know what to expect. I eventually learned how to best communicate with him over time.

Collapse
scottshipp profile image
scottshipp • Edited on

Ah the classic one word code review comment:

  • Nope.
  • Fix.
  • Why?
  • Seriously?
  • Lame.

etc.

It's hard to believe you could see comments like this in modern times, but you do.

Collapse
tschaka1904 profile image
Maximilian Koch Author

I find myself sometimes in a "battle of arguments". Very subjective opinions, everything gets questioned for the sake of because one doesn't like it. And suddenly there is a pull request with 60+ comments. Also not really effective.

I remember one particular situation, when there was an argument about if the http-error-code should be displayed in the UI or not. That one had a total of 80 comments.

After getting some sort of feeling for those kind of situations, I've started to cut down those comments by saying: "If you have any further questions around this, I'm more than happy to describe the reasons behind this on a white or on-screen. Just let me know."

"Lame" is also a rather interesting one!

Collapse
tschaka1904 profile image
Maximilian Koch Author • Edited on

Yeah, it always depends on the relationship between the devs. Like you would ask someone you don't really know "Would you like to go for a beer?", but with your best buddy it might be enough to just say: "Beer?" :D

In cross-site-teams this could be in issue. The team members get rarely the chance to get to know each other properly and some people might be put off by certain ways of communicating.

For me short and blunt is fine, but still would like have some sort of respect within a comment and at least the option of figuring out the why.

"Nope" feels kind of like = I don't like it, I don't see the point, but I also don't want to waste my time to explain you the why I feel like that.