DEV Community

Discussion on: How To Make The Most Out Of Pull Requests

Collapse
 
fidel3007 profile image
fidele007 (フィデル)

"Always verify all tests pass."

Does it mean you have to pull the PR branch to test the code yourself?

Collapse
 
kylegalbraith profile image
Kyle Galbraith

It depends on your CI/CD pipeline. I tend to have one setup that will just run the suite of tests and check ins to your features branch triggers a build. Then a developer can verify the test pass during the PR. The reviewer should still pull the code down if it is more than a one line code change to validate things have been accounted for.