DEV Community

Discussion on: Deploy a React app to DigitalOcean using Github Actions and Docker

Collapse
 
galakhov profile image
Dmitry

Hey there, it's a nice deploy.yml file! One suggestion (from docker) is to use:
echo "$GITHUB_TOKEN" | docker login docker.pkg.github.com -u $GITHUB_USERNAME --password-stdin
instead of:
docker login docker.pkg.github.com -u $GITHUB_USERNAME -p $GITHUB_TOKEN
for the security reasons.

err: WARNING! Using -*** the CLI is insecure. Use --password-stdin.
err: WARNING! Your password will be stored unencrypted in /home/***/.docker/config.json.
err: Configure a credential helper to remove this warning. See
err: https://docs.docker.com/engine/reference/commandline/login/#credentials-store
Enter fullscreen mode Exit fullscreen mode