DEV Community

Discussion on: How to tell a Junior Dev that what they've done is wrong?

Collapse
 
gewenyu99 profile image
Vincent Ge

Focus on the problem. Remove who did what, just explain the mistake.

"Look at this bit of code, notice this pointer that was never deallocated. That causes a memory leak."

That's the criticism.

If it's about conduct, you can instead focus on the action and it's affect on the team.

Say:
"Hey, do you have a moment? So earlier you had your phone out and was watching TikTok during the meeting. Having TikTok play during a meeting is distracting to those attending the meeting. Preferably we'd have the meeting in peace."

Instead of:
"Hey, do you have a moment? So earlier you had your phone out and was watching TikTok during the meeting. What you did during the meeting is distracting to those attending the meeting. Preferably you would let us have the meeting in peace."

Just stick to the facts and avoid excessive finger pointing. Explain what happened and it's affect and avoid being overtly personal. It's the actions, not them, but they should understand to avoid it down the road. I think as a professional, they should pick up on the constructive criticism non the less.

Collapse
 
nombrekeff profile image
Keff

Great tip, change the YOU with IT or WE. I could not agree more, this is something I picked up a time ago reading some post here on DEV, and have tried to apply it as much as possible. It can make a huge difference on how people interpret the criticism.