Thanks for sharing, that is a brilliant piece.
One question is looks to me not covered here: how do you find a good code reviewers?
For instance, Alice created a PR. Who and how should select code reviewers?
I think, there could be 3 strategies:
Every team member (Bob, Ann, Wagner, John) selects any PR's they want to review.
Cons: the approach does not guarantee enough number and quality of reviewers, because for instance Wagner and John have never worked with that part of business/tech domain.
Only team lead (Bob) is responsible for reviewing all PR's
Cons: tech lead could be overwhelmed with different tasks, so review quality would suffer; he becomes a single point of failure
Select reviewers based on experience in affected code components, modules, libraries and frameworks
Cons: it could require a plenty of time to investigate, especially when the team is 10+ developers.
Please share your thoughts on this question.
What strategies have you used and have you met any issues with them?
Thanks for sharing, that is a brilliant piece.
One question is looks to me not covered here: how do you find a good code reviewers?
For instance, Alice created a PR. Who and how should select code reviewers?
I think, there could be 3 strategies:
Please share your thoughts on this question.
What strategies have you used and have you met any issues with them?
Thank you for the comment, and I think it's a good point!
To be honest, I select the strategies depending on the situation.
I usually select the "3" way and I don't have experience in working in a team whose members are more than 10 (basically 2 ~ 5 members).