DEV Community

Discussion on: How to painlessly turn on ESLint rules

Collapse
 
hjylewis profile image
Henry Lewis

Yeah, I've actually done something similar in the past. It really depends on the developers and the code base. That approach proves difficult when you have CI running a validation check on your entire code base.

Another disadvantage I found with that approach was that often PRs became filled with unrelated changes which made them hard to review. The pre-commit hook forces you to make changes to a file that you are just trying to make a small change to and might not know super well.

What's nice about esplint is that it alerts you to the violations and prevents new ones but also lets you fix the old violations at your own pace. Again, it really depends on the developers and the code base in question.