do you think isValidCoupon is more suitable than applyCouple in your use case?
const isValidCoupon = coupon && coupon.unused && isCouponCompatible(product, coupon);
Very good point 👍
Even the other Boolean could be better named to isSaleActive rather than applySale.
isSaleActive
applySale
I'll make both changes.
Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment's permalink.
Hide child comments as well
Confirm
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
do you think isValidCoupon is more suitable than applyCouple in your use case?
Very good point 👍
Even the other Boolean could be better named to
isSaleActiverather thanapplySale.I'll make both changes.