DEV Community


Discussion on: When is your code 'good enough'?

ignoreintuition profile image
Brian Greig

I look for the following things:

  • does it meet the requirements
  • are all defects mitigated
  • is it fault tolerant
  • does it have a high degree of readability
  • is the documentation comprehensive
  • is it tested / testable
  • are we following DRY principals
  • is it loosely coupled to other components
  • are there any security risks

These are what I conder to be code quality metrics. If the above are met then the code is good. Obviously, some of these are easier to identify than others. You have to define your own thresholds for things like "What is comprehensive documentation?" This kind of thing can be more subjective than something like: "Are all defects mitigated?" which is just a simple yes / no answer.