DEV Community

Discussion on: Pull Requests Are Slowing You Down

Collapse
 
joelbonetr profile image
JoelBonetR πŸ₯‡

Pull Requests Are Slowing You Down

Aren't PRs meant just for that? Can't see the problem yet πŸ€·πŸ½β€β™‚οΈπŸ˜…

Pair programming as a solution... hmm I don't know Rick.
What if a team has an odd number of devs?
What if they both miss an error?
What if I have 2 seniors and 4 juniors?
What if some have a meeting but others don't?

Now being -more- serious, pair programming is OK in certain situations or as part of junior mentoring, but as a rule at work to use 8h a day it's mind-consuming and there's no reason for that, PRs are there for a good reason.

As advice, don't try to change the world without understanding how it works and why it works like that. Things are plenty of details when you look close to them and the major part had been studied.
Only raise new ways of doing when you understand something deeply, otherwise it's just posting your thoughts without taking the effort on learning about it.

Collapse
 
netch80 profile image
Valentin Nechayev

What if a team has an odd number of devs?

I've read a few articles on proper setup of pair programming. Well, it's definitely not a piece of cake. Two rules mentioned there are that 1) pairs should be tested for psychological compatibility (using non-critical tasks) and 2) there should be more than one trained peer for each developer, and they shall be regularly regroupped. Some part of team could work on less important tasks individually, so, odd number of devs doesn't that matter.
But another thing here is that pair programming is exhausting: it spends mental energy much faster than individual work. Exceptions are rare and shan't be relied on. So, it should be used only for most quality-required tasks.

What if they both miss an error?

Well, there always shall be a reviewer who wasn't involved in this change development.

See above for answers to rest.

As advice, don't try to change the world without understanding how it works and why it works like that.

Looking at entire poster's blog, I'm certain he decided to follow the way of highly contoversial provocative posts. This shall be taken into account, and our task is to get what we need from such a discussion kind.

Collapse
 
sainig profile image
Gaurav Saini

Totally agree on this, even some of the non-serious items feel legit. It’s very likely that both the devs may miss a particular error/scenario which can cause problems down the line.

And honestly I would much rather utilise a senior dev’s time in something useful unless they are mentoring like you said.

These type of controversial takes feel very disconnected from reality, and in some cases solely focused on generating traffic.

Collapse
 
joelbonetr profile image
JoelBonetR πŸ₯‡
These type of controversial takes feel very disconnected from reality, and in some cases solely focused on generating traffic.

100% agree, specially looking at the 3 posts of the OP. Can't find the sense on a single one of them.