First off, if you don’t know what atomic design is, I’ll give a brief primer below but I suggest you go to Brad Frost’s website and check it ou...
For further actions, you may consider blocking this person and/or reporting abuse
Nice way to think about it, I can explain to you my experience.
It's not done like that because atomic design applies to design as the name itself implies.
It's a bad way to structure code on a IT project because you lack dynamism and it makes you generate extra boilerplate and unnecessary overrides on your code.
The best you can do is to generate a SCSS framework according to your atomic design.
The framework can be structured like this but is not convenient, I'm sure you prefer to import a modals.scss instead importing an organisms.scss (which implicitly must need to import all primary files) so you'll be adding all the CSS on every page.
if you generate a modals.scss which contains the necessary items to create a modal you don't need to import the code that deals with... accordions or another item on the same site. Clearer, cleaner and more usable and better for performance.
Moreover the design system is meant to be used on design, not on development, at least not "as is". You'll need to define some primary attributes for each item on the design system but the rest leads to the context on where this items are shown.
For example all buttons can contain a border-radius: 4px; but if you want to create submit button it can be with a light background, a nice regular font and a light box-shadow, then you'll need to create a call to action button you probably will use a more aggressive box-shadow, a different background color and a heavier font. So there's no point on getting an atom called "button".
That's what BEM or other methodologies comes to solve at the end.
I disagree, from the perspective of coding frontend projects for almost 2 decades, atomic-design principles are fantastic way to organize code front-end code.
Many projects I see are a mess of 100+ components all in one folder (
src/components) and a new developer cannot possibly know which is a small basic one and which is a whole page (full of other components).just like you make order in your life in every aspect, like not mixing your underwear with your socks, you don't want throw all the components into one folder. it's a mess.
So, obviously there is a need for splitting things to groups.
Regarding your example of
button, you don't need to think of atomic-design components as a visual thing but more of a collection of concepts. A button can have a thousand appearances, don't matter. Still all buttons in the app should use thebuttoncomponent, to have a single-entity in charge of the buttons (and of course you may pass different optional variants for styling)Atomic design is ok as reference but not as a copy paste of methodology because it came to solve a different need. First of all you need to define what an atom is, and atoms are always the smaller building blocks.
What you talk about is components architecture in which you can group your items into src/components/anyTaxonomy, the difference between both ways to structure things is one little (maybe) but important.
That's why you use a component called button that can take some arg to define how it will look like, because it's called differently on each context, whereas if you use a strict atomic methodology (in which I must insist, is meant for design, not for coding even CSS) you'll end up with tones of little pieces of code that eventually form "molecules" and lately components.
Atomic design (note the design word) works well for designers because they can import visuals inside other visuals and if a visual is modified, it changes on everywhere. This is just what we want to reach on code, of course, but the way to achieve it easily is using components, not atoms, using variables for this styling as opposite to static references to a given object like in design frameworks or tools suck Sketch.
In CSS you can define "atoms" and "molecules" and make it working together pretty good mimicking this methodology as long as you use some pre-processor such SCSS and maintain your code well on the long time (you know, if it's a change, it's a change, not an addition or an override), but at the end you'll loose less time if you create components as well in CSS, usually known as BEM in which you define the blocks, the elements and the modifiers which if compared to a component architecture is pretty similar. A component has a scope, it's root element, child elements (that hopefully will be other components as well) and it's args (modifiers).
Hi, thanks for the thoughtful reply. I’m not quite sure I understand the implications you outlined. I think you made quite a few assumptions about how styling would work with an atomic design component folder structure.
There is no need to have a big organisms.scss file, each component can have its own styling. I don’t personally use scss, I use styled components which works very well with this structure. But the same can be achieved with scss without a problem.
Your point about there being no purpose in having an atom called “button” isn’t really connected to atomic design. That’s a project specific decision. There’s nothing wrong with making a second atom called SubmitButton if you need it, and keeping your buttons in a folder called atoms/buttons if you find that you have several different kinds of buttons.
It sounds like you made the assumption that I’m encouraging a super rigid structure, but my only point was that this is a “better” way to structure a React project in comparison to container / component structures. The “best” way is to utilize various patterns, such as atomic design, and incorporate the best parts into your own workflow.
This folder structure is a good starting point, but of course it can be extended / modified to suite the needs of a specific project. Each of my projects utilize a variation of this pattern, but by no means are they identical.
Thanks for reading!
I'll add an example using a basic common CSS (or Sass) methodology:
buttons.scss
@use './variables.scss'; .btn { border-radius: 4px; border: none; &.btn-primary { background: $primary-background; box-shadow: $top-layer-shadow; font-family: $bolder-typo; } &.btn-default { background: $default-background; box-shadow: $regular-layer-shadow; font-family: $regular-typo; } }home.scss
on HTML:
<link rel="../scss/home.scss" ... /> <header> <!-- some nice catching banner --> <button class="btn btn-primary"> Get yours at 50% discount! </button> </header> <!-- informative content --> <footer> <!-- some contact / leads secondary/basic form --> <button class="btn btn-default"> Submit </footer>As you can see it's very straightforward and very semantically strict which makes the things easier to devs.
Also on terms of performance you add what you need excepting few vars that hopelessly will come across with
variables.scss(which also could be named customize.scss or similar if you build a framework).Let's try to use atomic design to reach the same result:
../atoms/shadows.scss
.top-layer-shadow { box-shadow: 0 0 5px rgba(20, 20, 20, .8); } .regular-layer-shadow { box-shadow: 0 0 4px rgba(66, 66, 66, .55); }../atoms/backgrounds.scss
.default-background { background: #fefefe; } .primary-background { background: #fec940; }../atoms/fonts.scss
.regular-typo { font-family: 'Ubuntu-regular'; } .bolder-typo{ font-family: 'Ubuntu-bold'; }../atoms/buttons.scss
.btn { border-radius: 4px; border: none; }html:
<link rel="../scss/atoms/shadows.scss" ... /> <link rel="../scss/atoms/backgrounds.scss" ... /> <link rel="../scss/atoms/fonts.scss" ... /> <link rel="../scss/atoms/buttons.scss" ... /> <header> <!-- some nice catching banner --> <button class="btn primary-background bolder-typo top-layer-shadow "> Get yours at 50% discount! </button> </header> <!-- informative content --> <footer> <!-- some contact / leads secondary/basic form --> <button class="btn default-background regular-typo regular-layer-shadow"> Submit </button> </footer>you can, of course, import the things on the scss like that too as alternative:
home.scss
and load the home.scss on the html as single item, but this means you'll load across tones of super-componentized style sheets.
I'm not assuming a specific way to organize the code, i'm just translating the atomic design concept into the code.
I've a draft post about CSS methodologies, comparing them all and taking own conclusions which I'll finish to write when I can (I lack enough time to do it at this point, give me some weeks haha) it's not an easy task... on a little project, maybe. On a big project where you have a total line count over 10.000 lines of scss code or more it's a mess not using the right methodologies.
I've tried to translate atomic into scss properly before, the first time it was a mess for being more strict than needed on dev time, then I need to refactor things up and get a more usable code on it (i'm talking about a real project which is into production with 20K+ customers on it and which implies connection between many company Apps as a wrapper to add a service as value to our customers).
In fact I wrote a complete framework which I need to refactor for making it usable for everyone (adding customisation vars on each piece of code instead adding values according to our design system) so I've that pending too on my list and I'll give that free for everyone too so you can collaborate, give feedback and use it on your projects.
TL;DR:
Design has its process. On development, we have ours. It can not be done the same way because the tools we use are too different (on design you can easily copy-paste -> edit an element while on development you need to import -> override, causing overheating, being less able to override in the future and performance issues) so we need to found the best way to work on each development stage instead trying to find out a single way to work for eveyone.
I appreciate you breaking down an example! I see what you're saying, you find it difficult to pull out common styling while also having component specific styling.
The only part where I'm confused is why you feel you are forced to structure your scss files that way with an atomic design structure? I personally wouldn't do that either.
For example, I usually using CSS-in-JS libraries, which allows me to setup a "theme". This is where I would put my fonts, shadows, global button styles, etc. Material UI does this pretty well.
In SCSS, I imagine you can do something similar. But if you don't want a global theme file, you can still have a structure where your actual components are in, for example:
components/atoms/*and you have a "master" style sheet for all buttons atcomponents/atoms/buttons.scss. If you don't want your SCSS files in your components folder, then you can still do something likescss/buttons.scssno problem.Maybe I'm misunderstanding, but it looks like you are trying to enforce atomic design principles in your styles. Atomic design is an abstract way to categorize components, but there's no reason you have to apply the same structure to your styles.
Seems we are on a middle point. We does not use libraries or frameworks to handle styling because we are seeking performance on our projects and those frameworks and libraries are generic tools that solves a need but not in the better way (according to performance).
If you abstract your structure and keep your files on a correct way (semantically) and you inherit what is needed on each place you'll found yourself breaking up the atomic principles, that's because it's a design methodology which does not fit into a development process as is.
The only way to fit atomic design into development is having a greenfield where components look always the same regardless of the context (which is never true because you'll get a strict but unbalanced design) so you can reuse all components as is. Working on big projects makes you think how to handle the things for being nice to handle (or less hell like) for the developers while maintaining the performance and scalability (avoid overrides when possible, handle theming variables for re-desing easily and quickly and so).
The project structure deals with the speed devs can find the exact files they (we) need to edit something, avoid duplicity and avoid any other concern.
Using CSS-in-JS makes you handle a styling for a component directly inside the same component. This, even being ok in most cases must be used together with scss. Scss for the global things, css-in-js for specific component styling so you get an inheritance Sass -> component.
Imagine you have 68 components which uses an outline-color: blue and you need to redesign (by a rebranding process or whatever) that to be green. You'll need to edit it in 68 places instead doing that on a global place which is more correct and brainless.
It always depend on how big is your project and how much it's going to grow so you can analyze, choose and define the right methodology and patterns for it. You can fail and learn, you can success and learn too but there's experience from others that can help you with that too.
Maybe it would help if I explain what I typically do with this kind of setup.
I have a components folder with an atomic design structure, and I also have a "domains" folder so that I can create one-off components and business logic heavy components that are specific to a piece of the application. (resolving the limitation you mentioned about having greenfield components).
For styling, you wrongly state that css-in-js makes you handle styling directly in the component. At it's most basic level, yes, but I use a theme object in my projects, which contain styles for shadows, colors, spacing, etc, that can be setup in one place and used anywhere. I also have a globalStyles.ts file (for styled components) where I set global styles for typography and fonts.
I think it's important to remember that there is no universal project structure, and I never said there was. This project structure, like any other, can be adapted, modified, and built upon to suit the needs of a specific project (large and small).
nice I'm getting more what you tried to explain, thanks for clarifying!
Use it in production in a large application. Atomic design sounds fancy but it’s not a good solution.
Doesn’t simply the process and contains much boilerplate.
Totally agree
Having a single folder full of components just makes me think you haven’t worked on a large project. Even if you divide it into AMO folders you still end up with hundreds of components.
The better solution is the feature folder layout.
I have actually used this with large teams pretty successfully.
I'm not against a feature folder structure, I think it works fantastic in conjunction with an atomic design structure. There's no one size fits all.
The problem with feature folder layouts is that all components become tightly coupled with their domain context, which works okay for slow changing systems, but not so great for fast paced startups.
Atomic design takes way some of that domain specific context, which has its pros and cons. What I personally do is a combination of what you mentioned, a feature folder layout, along with an atomic design structure for more reusable components.
I found that even with devs coming in and out of a project, it generally works fine and keeps things organized. When we build out storybook for a component, it's easy to keep it in sync with what the design team has, and easy for the design team to audit the current state of the UI.
Perhaps my article came across as a bit dogmatic, but I'm aware that a little controversy usually gets a good conversation going :)
We usually make something like that:
having some styling globals 'variables.scss, common.scss, modals.scss, fonts.scss, colors.scss, accordion.scss and so' organised on semantically understandable directory tree.
Then each component has it's own scss where you import (@use) the necessary globals.
We find this was as more suitable for big projects but i'm not sure if it's the best way yet, how do you manage it?
“Well, a header is an organism, so let me check the organism folder.”
Or you could check feature/header/components
Is a header a "feature"? I thought it was a part of layout? What defines a feature?
But I see your point: there are logical ways to organize these things that can be more intuitive for a developer.
What I'm getting at is that atomic design provides more of a unified language for organization. More so, it's a common framework that designers follow, and could help back and forth communication.
Controversial? Certainly. Can it be improved upon? Hell yeah, that's what part 2 is for :)