DEV Community

Discussion on: Could you review my design, please?

Collapse
 
lexlohr profile image
Alex Lohr

First of all, you should probably use a monospace font for the code, e.g. fira code. This looks grotesk (please excuse the pun). In addition, the description and name look a bit misplaced outside of the box, maybe better put them inside?

Also, having a fixed width is wasting lots of space on wide screens and you have the same font size for every screen size. Maybe consider using calc() and vmin/vmax in your font size.

Collapse
 
starbist profile image
Silvestar Bistrović

Thanks for the suggestions!

Could you be more specific? Which description and name look misplaced?

The design would be responsive. I would definitely use a smaller font for smaller viewports.

Collapse
 
lexlohr profile image
Alex Lohr

which description and name look misplaced?

The one at the bottom of the lines of code boxes.

Thread Thread
 
starbist profile image
Silvestar Bistrović • Edited

You got it wrong. That is the current site, but I am talking about this prototype: projects.invisionapp.com/prototype....

I know the current site is not good. :-)

Thread Thread
 
lexlohr profile image
Alex Lohr

Ah, wrong URL, my bad. In this case, much better, but now it is a bit difficult to distinguish the code from the surrounding information.

Thread Thread
 
starbist profile image
Silvestar Bistrović

I am working on that, yeah. Check out the first revision: projects.invisionapp.com/prototype....

Thread Thread
 
lexlohr profile image
Alex Lohr

Much better. Go easy on the rounded corners, those look a bit overdone.