DEV Community

Discussion on: Mistakes I made in code reviews and what I do now

Collapse
 
lmika profile image
Leon Mika

Good points here. I agree with you that it's important to have some perspective, and not blindly follow "advice" you read in blog articles.

I once came across a series of articles by a maintainer of an OSS project we were using. After contributing a bug-fix and while waiting for the PR to be merged and release, I started reading through some of their blog posts, and a lot of their thoughts around PRs were very much antithetical to the points you raise: a lot of comments around control, protection of the codebase, nothing really about mentorship, etc. But the thing that disqualified all of that was it took a year for them to release the next version.